-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated the account from the 0.0.2 account to an account from th… #2690
Conversation
…e local node to track transaction costs. Signed-off-by: ebadiere <ebadiere@gmail.com>
The PR title seems to got cut off. Please update it before merging. |
Opened issue: #2700 Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Updated the private key to the hex ECDSA value. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the gasLimit to the required amount to activate a hollow account. Signed-off-by: ebadiere <ebadiere@gmail.com>
5ac94cf
to
3043906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
…h/hedera-json-rpc-relay into 2671-update-OPERATOR_ID Signed-off-by: ebadiere <ebadiere@gmail.com>
…ass. Signed-off-by: ebadiere <ebadiere@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
set to null Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG 👍
#2690) * fix: Updated the account from the 0.0.2 account to an account from the local node to track transaction costs. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Turning off test to potentially get through CI. Opened issue: #2700 Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: WIP: Pushing up to collaborate Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Updated the private key to the hex ECDSA value. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the gasLimit to the required amount to activate a hollow account. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added key format support to the serviceClient. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Extracted the createPrivateKeyBasedOnFormat(key) to the Utils class. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Updated import of createPrivateKeyBasedOnFormat from Utils. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed memory leak check. PR 26954 addresses memory leaks. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed null test because an env var which is a string cannot be set to null Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed the comment in the GH workflow Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
Use an account other than 0.0.2 for running tests. Removed "Out of Memory" error check in CI.. PR #2695 covers memory leaks.
Related issue(s): #2671