feat: add logsBloom class #2684
Conversation
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
|
|
|
||
| import { keccak256 } from 'ethereum-cryptography/keccak.js'; | ||
|
|
||
| const BYTE_SIZE = 256; |
There was a problem hiding this comment.
We might want to put this constant into a shared common place. I forgot what it is but there's a file we store constants, right?
| if (!bitvector) { | ||
| this.bitvector = new Uint8Array(BYTE_SIZE); | ||
| } else { | ||
| if (bitvector.length !== BYTE_SIZE) throw new Error('bitvectors must be 2048 bits long'); |
There was a problem hiding this comment.
Would be nice to have a refference link states why logsBloom must be 2048 bits (256 bytes).
| const mask = 2047; // binary 11111111111 | ||
|
|
||
| for (let i = 0; i < 3; i++) { | ||
| const first2bytes = new DataView(e.buffer).getUint16(i * 2); |
There was a problem hiding this comment.
Would be nice to explain along the steps through code comments
| e = keccak256(e); | ||
| const mask = 2047; // binary 11111111111 | ||
|
|
||
| for (let i = 0; i < 3; i++) { |
There was a problem hiding this comment.
Would be nice to explain along the steps through code comments
| const mask = 2047; // binary 11111111111 | ||
| let match = true; | ||
|
|
||
| for (let i = 0; i < 3 && match; i++) { |
There was a problem hiding this comment.
Would be nice to explain along the steps through code comments
There was a problem hiding this comment.
Nice work unblocking this.
I think @quiet-node had some good requests in here.
This is one of those classes that is likely rarely going to be updated but his deep crypto logic that is good to make sure if well commented and referenced so that the 1 time we do have to update it we understand what's going on
|
Superseded by #2785 |
Description:
This PR adds logsBloom object, which can take care of all bloom calculations, needed when there is missing logsBloom. Example are synthetic transactions, where we don't have logsBloom from the mirror node response. This PR only adds the class for this, calculations will be done in another to keep them tight and focused.
Related issue(s):
Fixes #2683
Notes for reviewer:
Checklist