-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds null check for param in validation #2682
fix: Adds null check for param in validation #2682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small nit
0fe53b7
to
a6fbb72
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
This reverts commit fb4ac2f. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
cd3faee
to
ce7bc07
Compare
This reverts commit ce7bc07. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
37c1e8d
to
7171bfd
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
7171bfd
to
62d0cb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a reminder and one small suggestion:
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
==========================================
+ Coverage 77.51% 78.27% +0.75%
==========================================
Files 41 27 -14
Lines 3269 2637 -632
Branches 698 579 -119
==========================================
- Hits 2534 2064 -470
+ Misses 487 373 -114
+ Partials 248 200 -48
Flags with carried forward coverage won't be shown. Click here to find out more. |
9df7404
to
7c3a07e
Compare
|
Description:
Currently, when we pass null as a param for getCode or any other endpoint, we do not return a descriptive response to the user. Thus, this PR adds a check in the validator, that throws an error when the param passed is null.
Files Changed :
src/validator/utils.ts
- Added a null check for the parametersrpc_batch2.spec.ts
- Fixed few failing testsType of Change:
Related issue(s):
Fixes #2376