fix: Adds null check for param in validation #2682

konstantinabl · 2024-07-08T07:24:16Z

Description:
Currently, when we pass null as a param for getCode or any other endpoint, we do not return a descriptive response to the user. Thus, this PR adds a check in the validator, that throws an error when the param passed is null.

Files Changed :

src/validator/utils.ts - Added a null check for the parameters
rpc_batch2.spec.ts - Fixed few failing tests

Type of Change:

Related issue(s):
Fixes #2376

github-actions · 2024-07-08T12:58:07Z

Acceptance Tests

  19 files 228 suites 33m 23s ⏱️
612 tests 602 ✔️ 4 💤 6 ❌
676 runs 666 ✔️ 4 💤 6 ❌

Results for commit 7c3a07e.

♻️ This comment has been updated with latest results.

packages/server/src/validator/utils.ts

packages/server/tests/acceptance/rpc_batch2.spec.ts

victor-yanev

LGTM, just one small nit

packages/server/src/validator/utils.ts

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

This reverts commit fb4ac2f. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

This reverts commit ce7bc07. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

github-actions · 2024-08-05T13:52:50Z

Tests

    3 files 165 suites 13s ⏱️
885 tests 884 ✔️ 1 💤 0 ❌
898 runs 897 ✔️ 1 💤 0 ❌

Results for commit 7c3a07e.

♻️ This comment has been updated with latest results.

victor-yanev

LGTM, I left a reminder and one small suggestion:

packages/server/tests/integration/server.spec.ts

packages/server/src/validator/utils.ts

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

codecov · 2024-08-05T21:17:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.27%. Comparing base (70e1be1) to head (9df7404).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   77.51%   78.27%   +0.75%     
==========================================
  Files          41       27      -14     
  Lines        3269     2637     -632     
  Branches      698      579     -119     
==========================================
- Hits         2534     2064     -470     
+ Misses        487      373     -114     
+ Partials      248      200      -48

Flag	Coverage Δ
relay	`78.27% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

sonarcloud · 2024-08-05T21:34:55Z

Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

konstantinabl linked an issue Jul 8, 2024 that may be closed by this pull request

"Error raised during getCode for address null" is not returned in the response to the client and can cause confusion. #2376

Closed

konstantinabl changed the title ~~Adds null check for param in validation~~ fix: Adds null check for param in validation Jul 15, 2024

konstantinabl added the bug Something isn't working label Jul 15, 2024

konstantinabl added this to the 0.52.0 milestone Jul 15, 2024

quiet-node modified the milestones: 0.52.0, 0.53.0 Jul 15, 2024

konstantinabl requested review from Ivo-Yankov, georgi-l95, natanasow and victor-yanev July 16, 2024 08:10

konstantinabl marked this pull request as ready for review July 16, 2024 15:45

konstantinabl requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners July 16, 2024 15:45

victor-yanev reviewed Jul 18, 2024

View reviewed changes

packages/server/src/validator/utils.ts Outdated Show resolved Hide resolved

georgi-l95 assigned konstantinabl Jul 19, 2024

georgi-l95 reviewed Jul 19, 2024

View reviewed changes

packages/server/src/validator/utils.ts Show resolved Hide resolved

victor-yanev reviewed Jul 19, 2024

View reviewed changes

packages/server/tests/acceptance/rpc_batch2.spec.ts Outdated Show resolved Hide resolved

victor-yanev reviewed Jul 19, 2024

View reviewed changes

packages/server/tests/acceptance/rpc_batch2.spec.ts Outdated Show resolved Hide resolved

konstantinabl requested review from georgi-l95 and victor-yanev July 29, 2024 16:05

victor-yanev previously approved these changes Jul 29, 2024

View reviewed changes

packages/server/src/validator/utils.ts Show resolved Hide resolved

konstantinabl dismissed victor-yanev’s stale review via 81c46a1 July 30, 2024 07:30

konstantinabl requested a review from victor-yanev July 30, 2024 07:30

konstantinabl force-pushed the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch 3 times, most recently from 0fe53b7 to a6fbb72 Compare August 1, 2024 15:42

Adds null check for param

85eae41

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl added 4 commits August 1, 2024 18:48

Omits validation check for undefined and not required params

01e291a

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Simplifies object check

cba3ce2

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Remove unecessary conditional

41c6f16

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Revert "Remove unecessary conditional"

d14ae20

This reverts commit fb4ac2f. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl force-pushed the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch 2 times, most recently from cd3faee to ce7bc07 Compare August 1, 2024 16:15

konstantinabl added 3 commits August 2, 2024 11:31

test ci

8a48e37

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Revert "test ci"

14ac373

This reverts commit ce7bc07. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Updates local node version

8b7b2d2

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl force-pushed the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch 3 times, most recently from 37c1e8d to 7171bfd Compare August 5, 2024 11:47

Enhance tests and revert object check

62d0cb8

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl force-pushed the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch from 7171bfd to 62d0cb8 Compare August 5, 2024 13:43

victor-yanev previously approved these changes Aug 5, 2024

View reviewed changes

packages/server/tests/integration/server.spec.ts Outdated Show resolved Hide resolved

packages/server/src/validator/utils.ts Show resolved Hide resolved

konstantinabl added 2 commits August 5, 2024 20:10

Removes leftove only in tests

4e24827

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Optimizes undefined check

14865a2

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl dismissed victor-yanev’s stale review via 14865a2 August 5, 2024 17:11

victor-yanev previously approved these changes Aug 5, 2024

View reviewed changes

Reverts param check suggested in comments

7c3a07e

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl dismissed victor-yanev’s stale review via 7c3a07e August 5, 2024 18:16

konstantinabl force-pushed the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch from 9df7404 to 7c3a07e Compare August 5, 2024 21:34

konstantinabl requested a review from victor-yanev August 5, 2024 21:44

victor-yanev approved these changes Aug 6, 2024

View reviewed changes

Ivo-Yankov approved these changes Aug 6, 2024

View reviewed changes

konstantinabl merged commit d895e27 into main Aug 6, 2024
60 of 65 checks passed

konstantinabl deleted the 2376-error-raised-during-getcode-for-address-null-is-not-returned-in-the-response-to-the-client-and-can-cause-confusion branch August 6, 2024 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Adds null check for param in validation #2682

fix: Adds null check for param in validation #2682

konstantinabl commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

victor-yanev left a comment

github-actions bot commented Aug 5, 2024 •

edited

Loading

victor-yanev left a comment •

edited

Loading

codecov bot commented Aug 5, 2024

sonarcloud bot commented Aug 5, 2024

fix: Adds null check for param in validation #2682

fix: Adds null check for param in validation #2682

Conversation

konstantinabl commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

Acceptance Tests

victor-yanev left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024 • edited Loading

Tests

victor-yanev left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Aug 5, 2024

Codecov Report

sonarcloud bot commented Aug 5, 2024

Quality Gate failed

konstantinabl commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Aug 5, 2024 •

edited

Loading

victor-yanev left a comment •

edited

Loading