-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds usage of internal cache for getFilterChanges #2668
Merged
ebadiere
merged 1 commit into
main
from
2646-eth_newfilter-eth_getfilterchanges-not-working
Jul 3, 2024
Merged
fix: Adds usage of internal cache for getFilterChanges #2668
ebadiere
merged 1 commit into
main
from
2646-eth_newfilter-eth_getfilterchanges-not-working
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
July 3, 2024 14:27
Quality Gate passedIssues Measures |
konstantinabl
requested review from
georgi-l95,
Ivo-Yankov,
natanasow and
victor-yanev
July 3, 2024 15:09
ebadiere
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
ebadiere
pushed a commit
that referenced
this pull request
Jul 3, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Jul 3, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Jul 3, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Jul 8, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Jul 8, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Jul 8, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
ebadiere
pushed a commit
that referenced
this pull request
Jul 9, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Jul 9, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Jul 9, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Jul 9, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
quiet-node
pushed a commit
that referenced
this pull request
Jul 15, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
quiet-node
pushed a commit
that referenced
this pull request
Jul 15, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
quiet-node
pushed a commit
that referenced
this pull request
Jul 15, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
pushed a commit
that referenced
this pull request
Jul 15, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
ebadiere
pushed a commit
that referenced
this pull request
Aug 1, 2024
Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Aug 1, 2024
* fix: upgrade @hashgraph/sdk from 2.44.0 to 2.46.0 Snyk has created this PR to upgrade @hashgraph/sdk from 2.44.0 to 2.46.0. See this package in npm: @hashgraph/sdk See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/935f0190-a061-4f84-9ff5-5e5a6754ca16?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Adds usage of internal cache for getFilterChanges (#2668) Changes current logic of getFilterChanges, so it considers changes from internal cache as well Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Added metrics around the HBar rate limiter to better track the (#2657) * fix: Added metrics around the HBar rate limiter to better track the HBar rate limiting. Signed-off-by: ebadiere <ebadiere@gmail.com> * Update packages/relay/src/lib/hbarlimiter/index.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: Removed the shouldLimit called counter. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: eth_getBlockTransactionCountByNumber is not supported in wss (#2650) fix: eth_getBlockTransactionCountByNumber is not supported in wss, should be treated as such Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, in getFilterChanges we get the filter id from the sharedCache. However, this won't work if the sharedCache option is disabled.
The PR modifies the filterService, so we check if the sharedCache is actually enabled.
Related issue(s):
Fixes #2646