-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve compatibility with standard ethereum tooling #2649
base: main
Are you sure you want to change the base?
fix: Improve compatibility with standard ethereum tooling #2649
Conversation
fd097d9
to
1505dde
Compare
1505dde
to
0bb7a2f
Compare
d10956d
to
777a5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, after this we can write some custom tests for the schema. aside from Jeromy comments, i think it looks okay. @Nana-EC has to modify the checks when this is approved in order to be merged.
ad4382d
to
824ed40
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…-apis Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…c; Adds file name in test header;Excludes dir from tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
This reverts commit 38f712e. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
db30f68
to
adb87ac
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
de0a650
to
583839f
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
===========================================
+ Coverage 44.11% 84.11% +40.00%
===========================================
Files 44 46 +2
Lines 3409 3457 +48
Branches 727 734 +7
===========================================
+ Hits 1504 2908 +1404
+ Misses 1651 326 -1325
+ Partials 254 223 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just some suggestions and comments
@@ -38,7 +38,7 @@ | |||
"axios-retry": "^3.5.1", | |||
"chai": "^4.3.6", | |||
"ethers": "^6.7.0", | |||
"execution-apis": "git://github.com/ethereum/execution-apis.git#584905270d8ad665718058060267061ecfd79ca5", | |||
"execution-apis": "git://github.com/ethereum/execution-apis.git#7907424db935b93c2fe6a3c0faab943adebe8557", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just being curious, where did you get this updated number?
@@ -5,6 +5,8 @@ const directoryPath = path.resolve(__dirname, '../../../../node_modules/executio | |||
const axios = require('axios'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing header license
/*-
/*-
*
* Hedera JSON RPC Relay
*
* Copyright (C) 2022-2024 Hedera Hashgraph, LLC
* ...
@@ -5,6 +5,8 @@ const directoryPath = path.resolve(__dirname, '../../../../node_modules/executio | |||
const axios = require('axios'); | |||
const openRpcData = require('../../../../docs/openrpc.json'); | |||
require('dotenv').config(); | |||
import Ajv from 'ajv'; | |||
import addFormats from 'ajv-formats'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -5,6 +5,8 @@ const directoryPath = path.resolve(__dirname, '../../../../node_modules/executio | |||
const axios = require('axios'); | |||
const openRpcData = require('../../../../docs/openrpc.json'); | |||
require('dotenv').config(); | |||
import Ajv from 'ajv'; | |||
import addFormats from 'ajv-formats'; | |||
import { signTransaction } from '../../../relay/tests/helpers'; | |||
import { expect } from 'chai'; | |||
let currentBlockHash; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up this session. I noticed that both import
and require
syntaxes are being used for importing dependencies. To conform to ES6 standards, please use import
instead of require
. Additionally, let's improve readability by adding some empty lines between the imports section and the variable declaration section.
Description:
Currently, our validation process only checks the presence of fields returned by our API, without verifying the format of these fields. This can lead to inconsistencies and potential errors.
Changes introduced:
Related issue(s):
Fixes #2108