-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowed eth_call to accept null/empty tx.to to simulate deploying smart contracts #2647
feat: allowed eth_call to accept null/empty tx.to to simulate deploying smart contracts #2647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested improvement
…ng smart contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
22684c3
to
2c9aa3b
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
2c9aa3b
to
4b09dcb
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
4b09dcb
to
b8472bf
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ng smart contracts (#2647) * feat: allowed eth_call to accept null/empty tx.to to simulate deploying smart contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: added support for `to` being empty or undefined Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: removed unnecessary test cases Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
Description:
Originally, the validation in the Relay object would stop the request if its
calldata.to
field was null or empty because the mirror-node didn't allow a nullableto
field. However, after this PR, the mirror-node now allows a nullableto
field. This update changes the validation so the Relay can accept requests with ato
field that is null or empty.Related issue(s):
Fixes #2334
Notes for reviewer:
Checklist