feat: allowed eth_call to accept null/empty tx.to to simulate deploying smart contracts #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Nana-EC
requested review from
Ivo-Yankov,
georgi-l95,
konstantinabl,
natanasow and
victor-yanev
…ng smart contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
2334-eth_call-errors-out-when-transactionto-is-set-to-null
branch
2 times, most recently
from
22684c3
to
2c9aa3b
Compare
quiet-node
commented
Jul 11, 2024
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
2334-eth_call-errors-out-when-transactionto-is-set-to-null
branch
from
2c9aa3b
to
4b09dcb
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
2334-eth_call-errors-out-when-transactionto-is-set-to-null
branch
from
4b09dcb
to
b8472bf
Compare
|
Nana-EC
approved these changes
Jul 11, 2024
quiet-node
deleted the
2334-eth_call-errors-out-when-transactionto-is-set-to-null
branch
ebadiere
pushed a commit
that referenced
this pull request
Aug 1, 2024
…ng smart contracts (#2647) * feat: allowed eth_call to accept null/empty tx.to to simulate deploying smart contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: added support for `to` being empty or undefined Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: removed unnecessary test cases Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Originally, the validation in the Relay object would stop the request if its
calldata.tofield was null or empty because the mirror-node didn't allow a nullabletofield. However, after this PR, the mirror-node now allows a nullabletofield. This update changes the validation so the Relay can accept requests with atofield that is null or empty.Related issue(s):
Fixes #2334
Notes for reviewer:
Checklist