-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduced the SDK usage in batch 3 to stablize the batch #2625
Conversation
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
|
Nice change, I have also noticed the same happen in the API Batch 1 tests, so it would also be nice to apply this there. I hope we have also brought this up to the SDK team? It looks like a very frustrating error which might make some users reconsider using the javascript SDK overall. |
I have applied this same logic to batch 1 before and recently batch 1 seems pretty stablized. Please ping me when you catch batch 1 being flaky again. regarding bringing this up to the SDK, I think the timeout makes sense and necessary. It's jsut because we exshaustively and repeatedly use the SDK, and test cases happen quite fast hence the timeout happened. |
Description:
Initially, batch 3 frequently failed with the
GrpcServiceError: gRPC service failed with status: TIMEOUT
error. This occurred because batch 3 contained consecutive test cases that exhaustively utilized the SDK to retrieve and prepare for testing materials. This PR addresses the issue by reducing the SDK usage and delegating some tasks to the relay in batch 3. This prevents the exhaustive use of the SDK and thereby avoids the GrpcServiceError: gRPC service failed with status: TIMEOUT error.Related issue(s):
Fixes #2568
Notes for reviewer:
Checklist