Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduced the SDK usage in batch 3 to stablize the batch #2625

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Jun 26, 2024

Description:
Initially, batch 3 frequently failed with the GrpcServiceError: gRPC service failed with status: TIMEOUT error. This occurred because batch 3 contained consecutive test cases that exhaustively utilized the SDK to retrieve and prepare for testing materials. This PR addresses the issue by reducing the SDK usage and delegating some tasks to the relay in batch 3. This prevents the exhaustive use of the SDK and thereby avoids the GrpcServiceError: gRPC service failed with status: TIMEOUT error.

Related issue(s):

Fixes #2568

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node added the enhancement New feature or request label Jun 26, 2024
@quiet-node quiet-node added this to the 0.51.0 milestone Jun 26, 2024
@quiet-node quiet-node self-assigned this Jun 26, 2024
@quiet-node quiet-node linked an issue Jun 26, 2024 that may be closed by this pull request
@quiet-node quiet-node requested a review from a team as a code owner June 26, 2024 22:35
Copy link

sonarcloud bot commented Jun 26, 2024

Copy link

Tests

    2 files  157 suites   14s ⏱️
854 tests 853 ✔️ 1 💤 0
866 runs  865 ✔️ 1 💤 0

Results for commit 910d476.

Copy link

github-actions bot commented Jun 26, 2024

Acceptance Tests

  16 files  209 suites   28m 29s ⏱️
603 tests 599 ✔️ 4 💤 0
640 runs  636 ✔️ 4 💤 0

Results for commit 910d476.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node marked this pull request as draft June 26, 2024 23:01
@victor-yanev
Copy link
Contributor

Nice change, I have also noticed the same happen in the API Batch 1 tests, so it would also be nice to apply this there.

I hope we have also brought this up to the SDK team? It looks like a very frustrating error which might make some users reconsider using the javascript SDK overall.

@quiet-node quiet-node marked this pull request as ready for review June 27, 2024 17:06
@quiet-node
Copy link
Member Author

quiet-node commented Jun 27, 2024

Nice change, I have also noticed the same happen in the API Batch 1 tests, so it would also be nice to apply this there.

I hope we have also brought this up to the SDK team? It looks like a very frustrating error which might make some users reconsider using the javascript SDK overall.

I have applied this same logic to batch 1 before and recently batch 1 seems pretty stablized. Please ping me when you catch batch 1 being flaky again.

regarding bringing this up to the SDK, I think the timeout makes sense and necessary. It's jsut because we exshaustively and repeatedly use the SDK, and test cases happen quite fast hence the timeout happened.

@quiet-node quiet-node merged commit 29d2e11 into main Jun 27, 2024
37 of 38 checks passed
@quiet-node quiet-node deleted the 2568-api-batch-3-is-a-flaky-test branch June 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Batch 3 is a flaky test.
3 participants