Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Golang JSON RPC methods usage example. #2586

Merged
merged 9 commits into from
Jun 28, 2024
Merged

feat: Golang JSON RPC methods usage example. #2586

merged 9 commits into from
Jun 28, 2024

Conversation

arianejasuwienas
Copy link
Contributor

Description:
Golang JSON RPC methods usage example.

@arianejasuwienas
feat: Golang JSON RPC methods usage example.
71975b9 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Tests

    2 files  157 suites   15s ⏱️
853 tests 852 ✔️ 1 💤 0 ❌
865 runs  864 ✔️ 1 💤 0 ❌

Results for commit 8e8fab7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Acceptance Tests

  15 files  204 suites   27m 31s ⏱️
602 tests 598 ✔️ 4 💤 0 ❌
639 runs  635 ✔️ 4 💤 0 ❌

Results for commit 8e8fab7.

♻️ This comment has been updated with latest results.

@arianejasuwienas
feat: tests
d6fead6 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas arianejasuwienas marked this pull request as ready for review June 13, 2024 08:25
quiet-node
quiet-node reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left some comments and Qs.

tools/golang-json-rpc-tests/main.go Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Outdated Show resolved Hide resolved
AlfredoG87
AlfredoG87 previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 added the enhancement New feature or request label Jun 13, 2024
@AlfredoG87 AlfredoG87 added this to the 0.50.0 milestone Jun 13, 2024
@AlfredoG87 AlfredoG87 added the P3 label Jun 13, 2024
@arianejasuwienas arianejasuwienas mentioned this pull request Jun 14, 2024
Closed
4 tasks
@arianejasuwienas arianejasuwienas linked an issue Jun 14, 2024 that may be closed by this pull request
Analyze Hedera EVM Compatibility with the Ethereum Go-client #788 #2597
Closed
4 tasks
@arianejasuwienas
feat: golang issues description
0fc1c42 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Nana-EC
Nana-EC reviewed Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

tools/golang-json-rpc-tests/.env.sample Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/README.md Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/README.md Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/README.md Outdated Show resolved Hide resolved
tools/golang-json-rpc-tests/main.go Show resolved Hide resolved
@arianejasuwienas
feat: golang issues description moved to the separate task
5621744 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@quiet-node quiet-node modified the milestones: 0.50.0, 0.51.0 Jun 17, 2024
@arianejasuwienas
test: adding sample smart contract to the tests
9f21c68 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
test: adding eth call results to the message
b1943b7 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
test: getting rid of duplicated and unused functions
df804fc 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
test: wss support
2715180 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
test: wss support readme
8e8fab7 
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

quiet-node
quiet-node approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM!

@arianejasuwienas arianejasuwienas merged commit c7e4099 into main Jun 28, 2024
30 of 33 checks passed
@arianejasuwienas arianejasuwienas deleted the golang-json-rpc branch June 28, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC left review comments

@quiet-node quiet-node quiet-node approved these changes

@AlfredoG87 AlfredoG87 AlfredoG87 left review comments

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@arianejasuwienas arianejasuwienas

Labels
enhancement New feature or request P3
Projects
None yet
Milestone
0.51.0
Development

Successfully merging this pull request may close these issues.

Analyze Hedera EVM Compatibility with the Ethereum Go-client #788
4 participants
@arianejasuwienas @Nana-EC @quiet-node @AlfredoG87