Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented eth_newFilter to WS server #2553

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented May 30, 2024

Description:

  • implemented eth_newFilter to WS server
  • added acceptance tests to cover new support

Fixes #2552
Fixes #2548

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node added the enhancement New feature or request label May 30, 2024
@quiet-node quiet-node added this to the 0.49.0 milestone May 30, 2024
@quiet-node quiet-node self-assigned this May 30, 2024
@quiet-node quiet-node linked an issue May 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 30, 2024

Tests

    2 files  149 suites   14s ⏱️
833 tests 832 ✔️ 1 💤 0
845 runs  844 ✔️ 1 💤 0

Results for commit 2b4461f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 30, 2024

Acceptance Tests

  17 files  219 suites   29m 53s ⏱️
600 tests 595 ✔️ 3 💤 2
699 runs  694 ✔️ 3 💤 2

Results for commit 2b4461f.

♻️ This comment has been updated with latest results.

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 2552-implement-eth_newfilter-method-into-ws-server branch from 03d5e58 to 889dcd6 Compare May 30, 2024 23:39
@quiet-node quiet-node marked this pull request as draft May 31, 2024 00:31
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 2552-implement-eth_newfilter-method-into-ws-server branch from 4eccb0a to 2b4461f Compare May 31, 2024 00:49
@quiet-node quiet-node marked this pull request as ready for review May 31, 2024 00:49
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere ebadiere merged commit 3c16200 into main Jun 3, 2024
36 of 38 checks passed
@ebadiere ebadiere deleted the 2552-implement-eth_newfilter-method-into-ws-server branch June 3, 2024 20:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants