-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Makes ICacheClient return type promise and changes LRUCache accordingly #2410
fix: Makes ICacheClient return type promise and changes LRUCache accordingly #2410
Conversation
bad263e
to
48370eb
Compare
|
1291746
to
5ea2204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, I left a few suggestions
bf2b252
to
9740166
Compare
9740166
to
83ff74e
Compare
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
83ff74e
to
d2700ba
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…ined via ? operator Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
5b81b10
to
7a53da8
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
+ Coverage 77.44% 77.86% +0.41%
==========================================
Files 43 43
Lines 3330 3329 -1
Branches 707 706 -1
==========================================
+ Hits 2579 2592 +13
+ Misses 505 491 -14
Partials 246 246
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, a step in the right direction.
Description:
Currently, the redisCache service is implementing the ICacheClient interface. However, in this interface the methods are not asynchronous as it should be when we are using redis. The goal of this PR is to change the interface and make the methods asynchronous as well as adding specific interface for redis and the internal cache.
Main Files Changed
ICacheClient.ts
: Added Promise return types.IRedisCacheClient.ts
: Added an interface for the RedisCache service.localLRUCache.ts
: Changed method return types to Promise.redisCache.ts
: Changed method return types to Promise and added 'await' for asynchronous methods.eth.ts
: Updated methods to use Promise return types and added 'await'.cacheService.ts
: Made methods asynchronous, added return types, and implemented conditions to use internalCache when Redis is unavailable.Type of Change:
Related issue(s):
Fixes #2387