Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Error raised during getCode for address null" is not returned in the response to the client and can cause confusion. #2376

Closed
ebadiere opened this issue Apr 19, 2024 · 1 comment · Fixed by #2682
Closed

"Error raised during getCode for address null" is not returned in the response to the client and can cause confusion. #2376

ebadiere opened this issue Apr 19, 2024 · 1 comment · Fixed by #2682
Assignees
@konstantinabl
Labels
bug Something isn't working
Milestone
0.53.0

Comments

@ebadiere
Copy link
Collaborator

Description

"Unknown error invoking RPC" is returned to the client when in the logs we see "Error raised during getCode for address null". The "address is null" message should be returned to the client to give the user an idea of what is going on.

Steps to reproduce

  1. Run eth_getCode with a null address value.

Additional context

No response

Hedera network

mainnet

Version

v0.45.2

Operating system

Linux
@ebadiere ebadiere added the bug Something isn't working label Apr 19, 2024
@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 28, 2024

@quiet-node please add info based on your observation

@konstantinabl konstantinabl self-assigned this Jul 8, 2024
@konstantinabl konstantinabl linked a pull request Jul 8, 2024 that will close this issue
fix: Adds null check for param in validation #2682
Merged
5 tasks
@konstantinabl konstantinabl mentioned this issue Jul 16, 2024
Merged
5 tasks
@konstantinabl konstantinabl added this to the 0.53.0 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konstantinabl konstantinabl

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.53.0
Development

Successfully merging a pull request may close this issue.

fix: Adds null check for param in validation hashgraph/hedera-json-rpc-relay
3 participants
@ebadiere @konstantinabl @Nana-EC