Stricter repeat value validation (#294)

harrisiirak · Nov 16, 2022 · cac06b9 · cac06b9
1 parent 679aecd
commit cac06b9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/expression.js b/lib/expression.js
@@ -276,6 +276,10 @@ CronExpression._parseField = function _parseField (field, value, constraints) {
     var repeatInterval = 1;
     var atoms = val.split('/');
 
+    if (atoms.length > 2) {
+      throw new Error('Invalid repeat: ' + val);
+    }
+
     if (atoms.length > 1) {
       if (atoms[0] == +atoms[0]) {
         atoms = [atoms[0] + '-' + constraints.max, atoms[1]];

diff --git a/test/expression.js b/test/expression.js
@@ -283,6 +283,14 @@ test('invalid expression which has repeat negative number times', function(t) {
   t.end();
 });
 
+test('invalid expression which has multiple combined repeat cycles', function(t) {
+  t.throws(function() {
+    CronExpression.parse('0 5/5/5 * * *');
+  }, new Error('Invalid repeat: 5/5/5'));
+
+  t.end();
+});
+
 test('range test with value and repeat (second)', function(t) {
   var options = {
     currentDate: new CronDate('Wed, 26 Dec 2012 14:38:53')