Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/3rd/tiff: Remove third-party TIFF library #340

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

tuffnatty
Copy link
Member

@tuffnatty tuffnatty commented Nov 12, 2023

2023-11-12 01:24 UTC+0100 Phil Krylov (phil a t krylov.eu)
  * src/3rd/Makefile
  - src/3rd/tiff/
  * package/harbour.spec
  * README.md
    - Removed third-party TIFF library. It's not clear why it was even included,
      it's not C90 compatible anymore, and a major pain to maintain.

Even @vszakats who added this has removed libtiff in his fork.

@tuffnatty
Copy link
Member Author

This allows non-strict bcc build to finish when using the free non-C99-compliant Borland C++ 5.5 compiler.

@alcz
Copy link
Contributor

alcz commented Nov 15, 2023

C89/90 maintenance burden plus a slight number of CVE security issues...
https://www.cvedetails.com/vulnerability-list/vendor_id-2224/Libtiff.html
libtiff seems to be used by Harbour core developers, it even received patches for WinCE in the past
is it still the case?

@vszakats
Copy link
Member

vszakats commented Nov 15, 2023

I've added libtiff for convenience in 2012, but Harbour core or contribs never ended up depending on it for anything. Probably very few if anybody is using this. If someone does, it remains (of course) possible to build this outside Harbour. As part of core, it's a maintenance burden, with frequent CVEs, pending bugs, and a local patch to maintain, while making builds longer and more fragile for everybody. I deleted it in 2016.

@tuffnatty
Copy link
Member Author

OK, I am going to merge this.

  * src/3rd/Makefile
  - src/3rd/tiff/
  * package/harbour.spec
  * README.md
    - Removed third-party TIFF library. It's not clear why it was even
      included, it's not C90 compatible anymore, and a major pain to maintain.
@tuffnatty tuffnatty merged commit 1ba1f6b into harbour:master Dec 1, 2023
8 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants