Prevent bad access errors when part is undefined
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Marsup heyo, any chance I can get some eyes on this? would resolve something that's currently causing problems for me (described in the referenced issue) |
|
As mentioned on joi's side, I've fixed it with hapijs/joi#2986, thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve this issue that I'm running into: hapijs/joi#2974 (comment)
There may be a deeper issue worth resolving with regard to
evaluate()being called withpart === undefined, but I haven't dug that deep.Either way, I'd expect that it's worth handling this situation gracefully (as is already the case when
part === null) rather than letting the type error occur on line 385 where it attempts to callpart[internals.symbol].