Fix is_() type annotations. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offbyone
approved these changes
Aug 11, 2021
| @@ -1,4 +1,4 @@ | |||
| from typing import Optional, Type, TypeVar, Union, overload | |||
| from typing import Optional, Type, TypeVar, overload, Any | |||
There was a problem hiding this comment.
nit: this probably doesn't pass an isort check
There was a problem hiding this comment.
Weird - I did run the linting through tox.
There was a problem hiding this comment.
Looks like we might have lost isort at some point. Hmph.
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 4, 2022
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by openembedded#150 openembedded#141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 openembedded#160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects openembedded#170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by openembedded#150 openembedded#135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by openembedded#157 openembedded#156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations openembedded#180 <hamcrest/PyHamcrest#180> Misc ------------- - openembedded#150 <hamcrest/PyHamcrest#150> openembedded#159 <hamcrest/PyHamcrest#159> openembedded#162 <hamcrest/PyHamcrest#162> openembedded#163 <hamcrest/PyHamcrest#163> openembedded#166 <hamcrest/PyHamcrest#166> openembedded#175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 4, 2022
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by openembedded#150 openembedded#141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 openembedded#160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects openembedded#170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by openembedded#150 openembedded#135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by openembedded#157 openembedded#156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations openembedded#180 <hamcrest/PyHamcrest#180> Misc ------------- - openembedded#150 <hamcrest/PyHamcrest#150> openembedded#159 <hamcrest/PyHamcrest#159> openembedded#162 <hamcrest/PyHamcrest#162> openembedded#163 <hamcrest/PyHamcrest#163> openembedded#166 <hamcrest/PyHamcrest#166> openembedded#175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 4, 2022
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by openembedded#150 openembedded#141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 openembedded#160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects openembedded#170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by openembedded#150 openembedded#135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by openembedded#157 openembedded#156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations openembedded#180 <hamcrest/PyHamcrest#180> Misc ------------- - openembedded#150 <hamcrest/PyHamcrest#150> openembedded#159 <hamcrest/PyHamcrest#159> openembedded#162 <hamcrest/PyHamcrest#162> openembedded#163 <hamcrest/PyHamcrest#163> openembedded#166 <hamcrest/PyHamcrest#166> openembedded#175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Jan 5, 2022
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by #150 #141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 #160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects #170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by #150 #135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by #157 #156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations #180 <hamcrest/PyHamcrest#180> Misc ------------- - #150 <hamcrest/PyHamcrest#150> #159 <hamcrest/PyHamcrest#159> #162 <hamcrest/PyHamcrest#162> #163 <hamcrest/PyHamcrest#163> #166 <hamcrest/PyHamcrest#166> #175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by #150 #141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 #160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects #170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by #150 #135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by #157 #156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations #180 <hamcrest/PyHamcrest#180> Misc ------------- - #150 <hamcrest/PyHamcrest#150> #159 <hamcrest/PyHamcrest#159> #162 <hamcrest/PyHamcrest#162> #163 <hamcrest/PyHamcrest#163> #166 <hamcrest/PyHamcrest#166> #175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
Changelog: ========= Features ------------- - * Adds the tests to the sdist. Fixed by #150 #141 <hamcrest/PyHamcrest#141> - * Update the CI to test Python 3.10 #160 <hamcrest/PyHamcrest#160> - * Add pretty string representation for matchers objects #170 <hamcrest/PyHamcrest#170> Bugfixes ------------ - * Test coverage is now submitted to codecov.io. Fixed by #150 #135 <hamcrest/PyHamcrest#135> - Change to the ``has_entry()`` matcher - if exactly one key matches, but the value does not, report only the mismatching value. Fixed by #157 #156 <hamcrest/PyHamcrest#156> - * Fix is_() type annotations #180 <hamcrest/PyHamcrest#180> Misc ------------- - #150 <hamcrest/PyHamcrest#150> #159 <hamcrest/PyHamcrest#159> #162 <hamcrest/PyHamcrest#162> #163 <hamcrest/PyHamcrest#163> #166 <hamcrest/PyHamcrest#166> #175 <hamcrest/PyHamcrest#175> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fis the
is_()type hint issue shown by #178 and #179.