Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix false positive on mailto links #5

Merged
merged 2 commits into from
Aug 9, 2023
Merged

fix false positive on mailto links #5

merged 2 commits into from
Aug 9, 2023

Conversation

port19x
Copy link
Contributor

@port19x port19x commented Aug 9, 2023

fixes #4

@port19x
Copy link
Contributor Author

port19x commented Aug 9, 2023

I have never written any ruby before so please verify if this actually makes sense

@hahwul
Copy link
Owner

hahwul commented Aug 9, 2023

@port19x
Wow, I really appreciate your input and the PR you sent over! Your suggestions have been super helpful. I've made some additional tweaks to the code to handle different scenarios even better. Once everything's merged, I'll get ready to roll out the release :D

@hahwul hahwul merged commit 6288629 into hahwul:main Aug 9, 2023
hahwul added a commit that referenced this pull request Aug 9, 2023
@hahwul
(#5) Improve code
0f5de6c
@port19x port19x deleted the main-1 branch August 11, 2023 07:27
port19x added a commit to port19x/port19.xyz that referenced this pull request Aug 11, 2023
@port19x
ci: bump deadfinder version
0813ef8 
hahwul/deadfinder#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahwul hahwul hahwul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mailto links are handled incorrectly
2 participants
@port19x @hahwul