-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Added HAFS v2.0.0 release notes along with physics schemes. #273
Open
jdkublnick
wants to merge
92
commits into
hafs-community:develop
Choose a base branch
from
jdkublnick:text/us-253
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
gspetro-NOAA
reviewed
Jun 7, 2024
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
gspetro-NOAA
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a few questions for @BinLiu-NOAA .
Could you please sync this PR branch with the latest HAFS develop branch? |
Comments have been Addressed and PR branch has been synced with the latest HAFS develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issues addressed (optional)
N/A
Dependencies (optional)
N/A
Contributors (optional)
@gspetro-NOAA .
Content comes from release notes and physics slides provided by @BinLiu-NOAA , @WeiguoWang-NOAA , @AndrewHazelton
Tests conducted
None required. Docs build successfully on RTD from my fork and can be viewed here: https://jdk-hafs.readthedocs.io/en/text-us-253/index.html
Application-level regression test status
None required