Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop]: Added HAFS v2.0.0 release notes along with physics schemes. #273

Open
wants to merge 92 commits into
base: develop
Choose a base branch
from
Open

[develop]: Added HAFS v2.0.0 release notes along with physics schemes. #273

wants to merge 92 commits into from

Conversation

jdkublnick
Copy link
Contributor

@jdkublnick jdkublnick commented Jun 6, 2024 •
edited by gspetro-NOAA
Loading

Description of changes

  • Added HAFS v2.0.0 release notes under technical overview rst
  • Added physics schemes rst file

Issues addressed (optional)

N/A

Dependencies (optional)

N/A

Contributors (optional)

@gspetro-NOAA .
Content comes from release notes and physics slides provided by @BinLiu-NOAA , @WeiguoWang-NOAA , @AndrewHazelton

Tests conducted

None required. Docs build successfully on RTD from my fork and can be viewed here: https://jdk-hafs.readthedocs.io/en/text-us-253/index.html

Application-level regression test status

None required

jdkublnick and others added 9 commits June 28, 2024 14:14
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
09105f3 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
7a5ec25 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
6517b9f 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
bbb7018 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
f6af352 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
566d403 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/Backgroundinfo/TechnicalOverview.rst
7bfafbd 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/CustomizingTheWorkflow/PhysicsSchemes.rst
07d889c 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@jdkublnick @gspetro-NOAA
Update doc/UsersGuide/source/CustomizingTheWorkflow/PhysicsSchemes.rst
c817975 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review June 28, 2024 18:40
gspetro-NOAA
gspetro-NOAA approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a few questions for @BinLiu-NOAA .

@BinLiu-NOAA
Copy link
Collaborator

Could you please sync this PR branch with the latest HAFS develop branch?

@jdkublnick
Copy link
Contributor Author

Comments have been Addressed and PR branch has been synced with the latest HAFS develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@BinLiu-NOAA BinLiu-NOAA Awaiting requested review from BinLiu-NOAA BinLiu-NOAA is a code owner

@ZhanZhang-NOAA ZhanZhang-NOAA Awaiting requested review from ZhanZhang-NOAA ZhanZhang-NOAA is a code owner

@KathrynNewman KathrynNewman Awaiting requested review from KathrynNewman KathrynNewman is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdkublnick @BinLiu-NOAA @gspetro-NOAA