Merge feature/hafsv1_basin to feature/hafsv2_basin #260
Conversation
…e, post, Kun Gao 10x10 degree VI/DA domain
lgramer
requested review from
BinLiu-NOAA,
ZhanZhang-NOAA,
KathrynNewman and
panll
as code owners
| url = https://github.com/ufs-community/ufs-weather-model.git | ||
| branch = develop | ||
| url = https://github.com/hafs-community/ufs-weather-model.git | ||
| branch = feature/hafsv1_basin |
There was a problem hiding this comment.
Is this necessary for moving nest upgrades @wramstrom ? I recommend that we use develop if possible.
| @@ -75,6 +82,8 @@ else | |||
| export RESTARTsrc=${WORKhafs}/intercom/RESTART_analysis | |||
| elif [ -e ${WORKhafs}/intercom/RESTART_vi ]; then | |||
| export RESTARTsrc=${WORKhafs}/intercom/RESTART_vi | |||
| elif [ -e ${WORKhafs}/intercom/RESTART_init ]; then | |||
There was a problem hiding this comment.
@lgramer remind me, is this change to properly read the init RESTART files to update the moving nests that are initialized in the forecast parent domain?
There was a problem hiding this comment.
I believe this is actually required for the analysis_merge to access the results of atm_init_storm1*, @ghassan-alaka. (Note that it only appears in the block under if [ ${MERGE_TYPE} = analysis ];.)
There was a problem hiding this comment.
Even though I couldn't preview this file, all changes should be specific to the multistorm workflow. This is OK.
There was a problem hiding this comment.
Sorry, @ghassan-alaka, this was a symbolic link to hafs_workflow.xml.in in hafsv1_final. So it is considered a "file type change" rather than an edit.
scripts/exhafs_launch.py
Outdated
There was a problem hiding this comment.
I don't see any conflicts here. Seems like everything added is can be turned off by setting run_multistorm=no.
scripts/exhafs_merge.sh
Outdated
There was a problem hiding this comment.
I don't see any conflicts here either. Nice work keeping modifications confined within ${RUN_MULTISTORM} == "YES"
sorc/hafs_forecast.fd
Outdated
There was a problem hiding this comment.
I don't think there would be any conflicts here, but will defer to @wramstrom .
Description of changes
Additions to create working HAFS/Multistorm workflow, incorporating moving nest fixes from @wramstrom and 10x10 degree VI/DA modifications by Kun Gao (GFDL).
Issues addressed (optional)
N/A
Dependencies (optional)
Contributors (optional)
Code fixes by @wramstrom and Kun Gao. Very substantial work on scripts by @ghassan-alaka. Overall workflow integration and testing by @lgramer .
Tests conducted
Tests with DA disabled, and with cold-start and warm-start (self-cycling) DA on two CentOS platforms (hera/CentOS and kjet).
Application-level regression test status
Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.