Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add victory screen #805

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add victory screen #805

merged 1 commit into from
Aug 5, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Aug 4, 2024 •
edited
Loading

  • Animate victory sweep
  • Replace win screen overlay with just text @ bottom that appears when we reach winner
  • Place player model at victory position
  • Set winner's color
  • Make winner strike a pose (or dance)
  • Add victory scenery to maps (just a bunch of band members and the victor)
  • Use animation events to trigger
    • win text
    • victory pose
    • back to main menu (implicitly, after victory pose)
  • Compose victory fanfare (start of wild metal band)
  • DRUM ROLL

@toberge toberge force-pushed the feature/win-screen branch 4 times, most recently from f84cfd7 to 3217dc8 Compare August 5, 2024 19:11
@toberge toberge marked this pull request as ready for review August 5, 2024 19:20
Fueredoriku
Fueredoriku approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature! 🥳

Tested and code looks good 👍

@toberge toberge merged commit 925e34e into dev Aug 5, 2024
3 checks passed
@toberge toberge deleted the feature/win-screen branch August 5, 2024 19:53
@toberge toberge mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toberge @Fueredoriku