-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/212 custom matchers for testing #219
Feat/212 custom matchers for testing #219
Conversation
fe89c2e
to
37c8fdb
Compare
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 96.00% 96.45% +0.44%
==========================================
Files 53 53
Lines 801 816 +15
Branches 11 10 -1
==========================================
+ Hits 769 787 +18
+ Misses 32 29 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
37c8fdb
to
fe8fd1c
Compare
11983c7
to
c8cf00e
Compare
* Renamed ColumnMultyTypeError --> ColumnMultiTypeError * SparkErrorWrapper now overrides equals and hashCode * CustomMatcher with better error messages
e1be01f
to
26ef2c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
great job 👍
Description
Custom matchers for testing Doric expected errors
Related Issue
#212
Motivation and Context
This change simplifies internal testing. It also tests like "normal" spark behaviour.
How Has This Been Tested?