-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/increase coverage #121
Conversation
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 81.87% 91.44% +9.58%
==========================================
Files 39 39
Lines 579 596 +17
Branches 7 10 +3
==========================================
+ Hits 474 545 +71
+ Misses 105 51 -54
Continue to review full report at Codecov.
|
@@ -90,6 +98,9 @@ private[sem] trait AggregationOps | |||
* "age" -> "max" | |||
* )) | |||
* }}} | |||
* @todo this example is not from doric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfonsorr take a look at this
* @group Aggregation Numeric Type | ||
* @see [[org.apache.spark.sql.functions.sum(e:* org.apache.spark.sql.functions.sum]] | ||
*/ | ||
def sum2Long[T: NumericIntegerType](col: DoricColumn[T]): LongColumn = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfonsorr DYT this name is OK?
3d9b542
to
8b216dd
Compare
No description provided.