Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS build #50

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Add macOS build #50

merged 1 commit into from
Jan 28, 2024

Conversation

jiuguangw
Copy link
Contributor

@jiuguangw jiuguangw commented Jan 28, 2024

This PR adds a macOS CI build.

The current Ubuntu build is not particularly meaningful because it does not install external dependencies and skips several tests. I addressed this by:

  • Downloading the pomdp-solve macOS binary. I attempted to build it from source but was unsuccessful (in both Ubuntu and macOS). I did not try the Ubuntu binary.
  • Building SARSOP (specifically, the fork for macOS) from source. Binaries are not supplied, and I had to make some modifications to the source code in order to build it successfully (the changes are saved as tests/appl.patch). I couldn't build it in Ubuntu (but didn't try very hard)
  • Exported POMDP_SOLVE_PATH, POMDPCONVERT_PATH, and POMDP_SOLVE_PATH. I think it's useful for these to exist in script form.
  • Added a CI check for pre-commit

Right now all 7 unit tests pass under macOS. I believe these are important features to facilitate future contributions to pomdp-py.

@zkytony
Copy link
Collaborator

zkytony commented Jan 28, 2024

Thank you so much! Agree - auto-setup of external solvers should be on the todo list.

@zkytony zkytony merged commit 9ae96d5 into h2r:master Jan 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants