Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpdef on variable #30

Closed
wants to merge 1 commit into from
Closed

Fix cpdef on variable #30

wants to merge 1 commit into from

Conversation

jiuguangw
Copy link
Contributor

@jiuguangw jiuguangw commented Jul 25, 2023

cpdef should not be defined on a variable. This was preventing me from successfully running a pip install on this package.

@zkytony
Copy link
Collaborator

zkytony commented Jul 25, 2023

Thanks! Also noticed this yesterday. The failure is likely due to the recent Cython 3.0.0 release.

@zkytony zkytony self-requested a review July 25, 2023 11:33
@jiuguangw
Copy link
Contributor Author

I don't have write access so you'll have to hit merge. Might also consider pinning your versions in setup.py and moving some of the extra dependencies to an extras_require field.

@zkytony
Copy link
Collaborator

zkytony commented Jul 25, 2023

Closing as this is merged via a new release.

@zkytony zkytony closed this Jul 25, 2023
@jiuguangw jiuguangw deleted the jw/fix branch July 25, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants