Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-226] ROC curve rendered for SVM plots in Sparkling Water #13

Merged
merged 3 commits into from
Nov 22, 2016

Conversation

mdymczyk
Copy link
Contributor

No description provided.

@micahstubbs
Copy link
Contributor

micahstubbs commented Nov 18, 2016

@mdymczyk looks nice! I'd like to verify this change. should I run sparkling water to do that?

edit: the answer is yes. below are the steps to reproduce the feature and test this PR

@micahstubbs
Copy link
Contributor

./gradlew clean publishToMavenLocal

@micahstubbs
Copy link
Contributor

micahstubbs commented Nov 18, 2016

to resolve internal/fs error:
from h2o-3 root directory rm -rf h2o-web/node_modules

@micahstubbs
Copy link
Contributor

screen shot 2016-11-17 at 5 11 09 pm

@micahstubbs
Copy link
Contributor

now we build sparkling water
./gradlew build -x test -x integTest

@micahstubbs
Copy link
Contributor

set version as well, since another h2o-3 major release has happened

screen shot 2016-11-17 at 5 18 48 pm

@micahstubbs
Copy link
Contributor

now we start Sparkling Water
cd bin
./sparkling-shell

scala> import org.apache.spark.h2o._
scala> H2OContext.getOrCreate(sc)

@micahstubbs
Copy link
Contributor

screen_shot_2016-11-17_at_6_38_15_pm

@micahstubbs
Copy link
Contributor

Uncaught ReferenceError: Unable to process binding "with: function (){return output }"(…)

screen shot 2016-11-17 at 6 41 15 pm

@micahstubbs
Copy link
Contributor

here is the block of code from flow-lib.js that produces the error

screen shot 2016-11-17 at 6 41 43 pm

@micahstubbs micahstubbs mentioned this pull request Nov 18, 2016
@mdymczyk
Copy link
Contributor Author

mdymczyk commented Nov 18, 2016

@micahstubbs turns out I just had to rebase master onto this branch and all is working, you can retest again.

  1. in h2o-3 run ./gradlew clean
  2. in h2o-flow do git pull and make
  3. in h2o-3 copy all .js files from h2o-web/src/main/resources/www/flow/js to h2o-web/lib/h2o-flow/build/js cp h2o-web/src/main/resources/www/flow/js/* h2o-web/lib/h2o-flow/build/js/
  4. in h2o-3 run ./gradlew publishToMavenLocal -x test
  5. in sparkling water run ./gradlew clean build -x test -x integTest
  6. in SW run bin/sparkling-shell
  7. in the shell run:
import org.apache.spark.h2o._
H2OContext.getOrCreate(sc)

In FlowUI run the SVM flow.

@micahstubbs
Copy link
Contributor

micahstubbs commented Nov 22, 2016

  1. in h2o-3 copy all .js files from
    h2o-web/src/main/resources/www/flow/js
    to
    h2o-web/lib/h2o-flow/build/js
    the command for that is
    cp h2o-web/src/main/resources/www/flow/js/* h2o-web/lib/h2o-flow/build/js/

@lo5 is this the sort of step that we should add to the Flow Makefile?

@micahstubbs
Copy link
Contributor

just verified that the ROC plot does render 🎉

here are the images from this last step:

In FlowUI run the SVM flow.

first we view example flows
01-view-example-flows

then we click Spark_SVM_Model.flow
02-spark_svm_model

we see some code cells. let's run them!
screen shot 2016-11-22 at 10 59 07 am

the result of running the code cells is an svm-model
screen shot 2016-11-22 at 11 00 01 am

when we click on the svm-model, we see the ROC plot
screen shot 2016-11-22 at 11 00 54 am

@micahstubbs
Copy link
Contributor

now we just need an answer from @lo5 on this question about how best to automate this manual copy step in build process

screen shot 2016-11-22 at 11 05 31 am

@lo5
Copy link
Member

lo5 commented Nov 22, 2016

@micahstubbs The usual release process is:

  1. ./release.sh 1.2.3 to push a new release to NPM.
  2. Bump the version in bower.json: https://github.com/h2oai/h2o-3/blob/master/h2o-web/bower.json

@micahstubbs micahstubbs merged commit 9d5d801 into master Nov 22, 2016
@micahstubbs
Copy link
Contributor

will now release 0.4.52 with a commit to master

@micahstubbs
Copy link
Contributor

ok, so it looks like the script ./release.sh 0.4.52 creates the commit for you. nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants