Big Move #2305
Merged
Big Move #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st-pasha
added
the
ITA
oleksiyskononenko
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we relocate all source files -- both C++ and Python -- into the
/srcdirectory.The reason for why this setup is preferred is explained in https://blog.ionelmc.ro/2014/05/25/python-packaging; however for us such move is in fact a necessity: with our previous setup it was impossible for
pytestto properly test datatable installed from a wheel. Although pytest may eventually fix this problem (pytest-dev/pytest#4714), for now the most reliable solution is to have thedatatable/folder not in the root of the repository.As for the
cfolder, there was no good reason to move it, except that now that we have thesrc/folder it seems only logical that the C++ code should also live there.Also, I've inserted
sys.path.insert(0, "src")in the tests/init.py and tests/conftest.py -- these are temporary changes, designed to ease the transition towards the new file layout.