Improve UZF #301
Merged
Improve UZF #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test and readthedocs are failing becasue of unrelated issues that are solved in PR #297. I would leave |
|
I made the requested changes. The failing tests are from a failing AHN3 request and not related to this PR |
dbrakenhoff
reviewed
Dec 18, 2023
nlmod/read/ahn.py
Outdated
| res = 5.0 | ||
| logger.warning( | ||
| "5 meter resolution is no langer available via wcs, try " | ||
| "nlmod.read.get_ahn4 ot obtain ahn with a 5m resolution. for " |
There was a problem hiding this comment.
typo ot = to, capitalize For
dbrakenhoff
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the UZF function:
maskargumentwc_filerecordargument to save a file with the water contentmask_obsto choose which cells to add an observation to