-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve output #297
Improve output #297
Conversation
@@ -113,6 +113,28 @@ def xy_to_icell2d(xy, ds): | |||
return icell2d | |||
|
|||
|
|||
def xy_to_row_col(xy, ds): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work on vertex grids as well, do we want to check for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added check, also in xy_to_icell2d. But I think we should improve these methods, as they will give a wrong result in variable gridsizes, where the closest centre of the cell in not equal to the cell the point is in.
nlmod/mfoutput/mfoutput.py
Outdated
@@ -88,6 +88,12 @@ def _create_da(arr, modelgrid, times): | |||
flopy modelgrid object | |||
times : list or array | |||
list or array containing times as floats (usually in days) | |||
add_nans : bool, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, but maybe dry_nans = True
is a bit clearer, instead of add_nans.
|
||
df = nlmod.read.geotop.get_kh_kv_table() | ||
gt = nlmod.read.geotop.add_kh_and_kv(gt, df) | ||
# again, but using the stochastic method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like stochastic is already tested in line before? Maybe modify comment to indicate why second test is different from first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 very minor comments.
Remove add_nans again, and just use the value for hdry or hnoflo to not add NaNs
This Pull Request does the following: