Consistently resolve transitive substitutions #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of substitution resolution inconsistently resolves transitive substitutions of Object contents because the Object is an unordered map. If a dependent is evaluated before the dependency, the dependent is not properly resolved.
For example:
c
will correctly resolve to5
ifb
has been resolved first. However, ifc
is resolved first,c
is evaluated to${a}
.According to HOCON docs,
This pull request does not specifically implement a "forward" or "backward looking" solution, but it does evaluate the graph for cycles and improves substitution resolution consistency.