-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quotation mark for String #22
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 96.69% 96.70% +0.01%
==========================================
Files 3 3
Lines 726 729 +3
==========================================
+ Hits 702 705 +3
Misses 17 17
Partials 7 7
☔ View full report in Codecov by Sentry. |
Hi, @gurkankaymak Could you please review this PR ? |
Hi @Rory-Z, sorry for the late response, |
Good idea, let me try it. |
Signed-off-by: Rory Z <16801068+Rory-Z@users.noreply.github.com>
Hi @gurkankaymak Please review again |
Thanks for your approved, can we merge this ? |
Are you sure this is the expected behavior for parsing quoted strings containing forbidden chars? For example, if my HOCON file looks like this:
Then loading that via
but I would have expected the quotes to be stripped. |
if the string element have forbidden characters or the string is a empty string, then add quotation mark for them
More info, please check https://go.dev/play/p/6blMUYTercu