Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings from RateMyProfessors.com #86

Merged
merged 3 commits into from
Aug 27, 2011
Merged

Ratings from RateMyProfessors.com #86

merged 3 commits into from
Aug 27, 2011

Conversation

styfle
Copy link

@styfle styfle commented Aug 24, 2011

I added the feature to view ratings from RateMyProfessors.com by clicking on the instructor's name. The problem is that I added the click event to the specific cell (td) which doesn't override the click event on row (tr). So needless to say, clicking on an instructor brings up their ratings AND adds the course. It would probably be best to remove the latter part to avoid the error message when a course is already added.

You can see the feature in action by visiting http://antplanner-fork.appspot.com

…me. It still needs work because clicking an instructor still adds the class to the calendar.
…In fact, if RMP does not have a first initial, there won't be a match. For example GOODRICH, M. is not listed with a first initial on RMP.
gumho added a commit that referenced this pull request Aug 27, 2011
Ratings from RateMyProfessors.com
@gumho gumho merged commit ea66593 into gumho:master Aug 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants