Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tsx support #96

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

evenstensberg
Copy link

#95

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evenstensberg 🤗

Adding this into the middle of the array messes up the test harness. If this should (purposefully) be loaded before babel is attempted, can you please adjust the tests appropriately? This also needs tests 🙏

index.js Show resolved Hide resolved
Copy link
Author

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated PTAL. The tests are passing for me (node v22.3.0)

@@ -498,6 +499,7 @@ var extensions = {
);
},
},
'tsx/dist/cjs/index.cjs',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add it to:

  • .tsx
  • .cts
  • .mjs - tsx will compile it down to CommonJS; minor caveat is that it won't handle TLA but this caveat exists with any ESM -> CommonJS compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants