Issue 303 allow kwargs for savefig #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…palencia/develop Release 0.19.0
…lt.savefig ``` plt.savefig(savefig, **save_kwargs) ```
guillermo-navas-palencia
requested changes
Mar 14, 2024
| @@ -608,7 +608,7 @@ def build(self, show_digits=2, add_totals=True): | |||
| return df | |||
|
|
|||
| def plot(self, metric="woe", add_special=True, add_missing=True, | |||
| style="bin", show_bin_labels=False, savefig=None, figsize=None): | |||
| style="bin", show_bin_labels=False, savefig=None, figsize=None, save_kwargs={}): | |||
There was a problem hiding this comment.
A function definition with a mutable type {} is bad practice. Please change to save_kwargs=None and amend the code appropriately.
There was a problem hiding this comment.
Same comment for the definitions below. Thanks!
…th a mutable type {} is a bad practice. Changing to save_kwargs=None
guillermo-navas-palencia
requested changes
Mar 15, 2024
guillermo-navas-palencia
approved these changes
Mar 25, 2024
guillermo-navas-palencia
merged commit 8de83e4
into
guillermo-navas-palencia:develop
2 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes add a new argument to method plot in BinningTable and derived classes in order to fix the issue related to labels cut off when saving chart to files.