Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add --clear option to the guardrails watch command. #944

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

JosephCatrambone
Copy link
Contributor

Adds --clear to the guardrails watch command to clear output logs. Also cleaned up some unused code (default write path) and made a few other code paths cleaner. Added unit tests for new feature.

@JosephCatrambone JosephCatrambone marked this pull request as ready for review July 18, 2024 22:07
dtam
dtam previously approved these changes Jul 18, 2024
Copy link
Contributor

@dtam dtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit but lgtm. world not going to end if we have a few extra #s

Copy link
Contributor

@dtam dtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i double approve of this after the update

@JosephCatrambone JosephCatrambone merged commit e289034 into main Jul 19, 2024
12 checks passed
@JosephCatrambone JosephCatrambone deleted the jc/add_watch_clear branch July 19, 2024 06:15
@zsimjee zsimjee added this to the v0.5.1 release tracker milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants