Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env var for configuring validation hub service base url #926

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

AlejandroEsquivel
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel commented Jul 16, 2024

Updated:

  • Added GR_VALIDATOR_HUB_SERVICE to override validator hub service API base url

In some cases overriding our base API url will allow customers to reach our servers when there are issues hitting API GW directly (see discussion around private subnets and API GW VPC interface endpoints)

Copy link
Collaborator

@CalebCourier CalebCourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It sets us up nicely for federated, privately hosted hubs if we ever go that route.

@dtam
Copy link
Contributor

dtam commented Jul 16, 2024

@AlejandroEsquivel is this good for merge? its draft

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review July 16, 2024 17:13
@zsimjee zsimjee merged commit a465d6c into 0.5.0-dev Jul 16, 2024
12 checks passed
@zsimjee zsimjee deleted the feat/api-urls-configurable branch July 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants