Bugfix: when 'None' is passed explicitly to _set_num_reasks we don't use the default of '1'. #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use the default of '1'.
dtam
reviewed
Jul 8, 2024
guardrails/guard.py
Outdated
| @@ -235,8 +235,15 @@ def configure( | |||
| self._set_tracer(tracer) | |||
| self._configure_telemtry(allow_metrics_collection) | |||
|
|
|||
| def _set_num_reasks(self, num_reasks: Optional[int] = 1): | |||
| self._num_reasks = num_reasks | |||
| def _set_num_reasks(self, num_reasks: Optional[int]): | |||
There was a problem hiding this comment.
im no lint/typing expert but surprised theres not a version of pyright that wants Optional[int] = None?
There was a problem hiding this comment.
tbh I quite detest this function signature. I could do _set_num_reasks(self, num_reasks: int = 1).
There was a problem hiding this comment.
Yeah, I like num_reasks: Optional[int] = None much more. Good suggestion.
dtam
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.