Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add guard watch and guard logger. #868

Merged
merged 27 commits into from
Jun 28, 2024

Conversation

JosephCatrambone
Copy link
Contributor

@JosephCatrambone JosephCatrambone commented Jun 26, 2024

guard_watch

New Features:

  • A multiprocessing + async safe logger.
  • A watcher command that can read (and tail in realtime) the logs.

TBD:

  • Where do we want the default location of the log file to be? (Defaulting to temp directory.)
  • What do we want the maximum lifetime of a log to be? (Defaulting to 100000 entries.)
  • What is the performance impact of the additional logging?

Performance implications:

  • Without logging: 7.99 seconds, 7.99 seconds, 8.04 seconds, 7.83 seconds, 7.97 seconds (Mean: 7.96sec +- 0.70sec)
  • With logging: 7.97 seconds, 7.82 seconds, 7.99 seconds, 7.81 seconds, 7.93 seconds (Mean: 7.90sec +- 0.75sec)

@JosephCatrambone JosephCatrambone marked this pull request as ready for review June 27, 2024 19:29
@CalebCourier
Copy link
Collaborator

LGTM! Last comment: Have we tested this with the guards running server-side as well as client-side? It's just interacting with a file so it looks like it should work in both scenarios, but we should be sure to test both.

@JosephCatrambone JosephCatrambone merged commit 7b91b88 into 0.5.0-dev Jun 28, 2024
12 checks passed
@JosephCatrambone JosephCatrambone deleted the jc/feat-guard-watch-log branch June 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants