Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GuardRunnable #782

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Migrate to GuardRunnable #782

merged 4 commits into from
Jun 4, 2024

Conversation

CalebCourier
Copy link
Collaborator

@CalebCourier CalebCourier commented May 21, 2024 •
edited
Loading

Summary:

  • Deprecates Guard.invoke
  • Adds GuardRunnable and Guard.to_runnable
    • Deprecates Validator.invoke
  • Adds ValidatorRunnable and Validator.to_runnable

Scheduled for v0.4.5

@CalebCourier CalebCourier marked this pull request as draft May 21, 2024 19:40
@CalebCourier CalebCourier requested review from zsimjee and a team May 21, 2024 19:40
@notion-workspace Notion Workspace
Copy link

Deprecate current Guard.invoke

@notion-workspace Notion Workspace
Copy link

Add a GuardRunnable class

@zsimjee zsimjee added this to the v0.4.5 release milestone May 21, 2024
@CalebCourier
Copy link
Collaborator Author

CalebCourier commented May 28, 2024 •
edited
Loading

TODO:

@CalebCourier CalebCourier marked this pull request as ready for review June 4, 2024 15:48
@CalebCourier CalebCourier mentioned this pull request Jun 4, 2024
Closed
@CalebCourier CalebCourier merged commit 8653668 into main Jun 4, 2024
20 checks passed
@CalebCourier CalebCourier deleted the guard-runnable branch June 4, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsimjee zsimjee zsimjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.5 release
Development

Successfully merging this pull request may close these issues.
2 participants
@CalebCourier @zsimjee