Fix Duplicate Validate Call #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious merge conflict
|
Should address part of #755 |
|
Can we add a test that ensures that validators aren't called multiple times? |
nichwch
approved these changes
May 9, 2024
Yes we can and should. Sorry didn't see this until too late, my bad. Tracked it here and assigned to myself: https://www.notion.so/guardrailsai/Finish-Validator-Service-Unit-Tests-99169cb441e543b4aae5d0e94947fa0d?pvs=4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicate validator.validate call that carried over from a previous merge conflict