Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/onfail enum match #701

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Bug/onfail enum match #701

merged 5 commits into from
Apr 9, 2024

Conversation

zsimjee
Copy link
Collaborator

@zsimjee zsimjee commented Apr 8, 2024 •
edited
Loading

This PR fixes

  1. [bug] DetectPII validator with on_fail=fix results in a TypeError when validation fails #693
  2. noop behavior. Currently, noop behavior forces a return of None at the field (for pydantic) or output (for string) level.

@zsimjee zsimjee marked this pull request as ready for review April 8, 2024 20:59
ShreyaR
ShreyaR approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@ShreyaR ShreyaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ShreyaR ShreyaR merged commit 762e1ea into main Apr 9, 2024
36 checks passed
@ShreyaR ShreyaR deleted the bug/onfail-enum-match branch April 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyaR ShreyaR ShreyaR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsimjee @ShreyaR