have stream generate ValidationOutcome #675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Streaming output originally looked like a string.
This formatting is unusable for several reasons. It also doesn't support streaming into pydantic models.
Changes
Generator[ValidationOutcome, None, None]
instead ofGenerator[str, None, None]
run
output, without doing ajson.dumps
run.py
into 4 files for readabilityNote: validation_passed is poorly calculated. We need to interop with validation better and expose why validation fails per unit.