Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valid_chess_moves_notebook #557

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

aaravnavani
Copy link
Contributor

This PR fixes this issue and makes it so that guard.output_schema can access properties like move in the valid_chess_moves notebook.

@aaravnavani aaravnavani changed the title Fix Property on Guard.output_schema Fix Property on guard.output_schema Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8833c05). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage        ?   82.80%           
=======================================
  Files           ?       93           
  Lines           ?     5757           
  Branches        ?        0           
=======================================
  Hits            ?     4767           
  Misses          ?      990           
  Partials        ?        0           
Flag Coverage Δ
unittests 82.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CalebCourier
Copy link
Collaborator

Hey @aaravnavani, thanks for the contribution! From what I can see this would fix the specific notebook in question where we first discovered the bug described in #430, but it doesn't necessarily address the underlying issue. If you're interested in pursuing a more wholistic fix we'd be more than happy to review. If not that's ok too, we might just change the PR title to something more specific like "Fix valid_chess_moves notebook".

@aaravnavani
Copy link
Contributor Author

@CalebCourier I see. I'll rename this PR and create a new PR for the more wholistic fix. Thanks!

@aaravnavani aaravnavani changed the title Fix Property on guard.output_schema Fix valid_chess_moves_notebook Jan 26, 2024
@CalebCourier CalebCourier merged commit 30ce6c4 into guardrails-ai:main Jan 29, 2024
36 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants