Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional JSON parsing #554

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Additional JSON parsing #554

merged 2 commits into from
Jan 24, 2024

Conversation

CalebCourier
Copy link
Collaborator

Original PR: #548

Addresses: #543

@CalebCourier
Copy link
Collaborator Author

After merging this we should refactor extract_json_from_ouput to also try to parse the block it extracts falling back on the next parsing method.

@CalebCourier CalebCourier marked this pull request as ready for review January 24, 2024 21:37
@zsimjee zsimjee merged commit c7c2a52 into main Jan 24, 2024
60 checks passed
@CalebCourier CalebCourier deleted the mory91/check-json-text branch March 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsimjee zsimjee zsimjee approved these changes

@ShreyaR ShreyaR Awaiting requested review from ShreyaR

@thekaranacharya thekaranacharya Awaiting requested review from thekaranacharya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalebCourier @zsimjee @mory91