Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Status #526

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Fix Status #526

merged 9 commits into from
Jan 5, 2024

Conversation

CalebCourier
Copy link
Collaborator

This PR applies a few fixes to the status that is calculated after validation is run.

  1. While subbing reasks with their fix values, if a reask does not have a fix value we leave the reask in. This allows us to see that the value was not fixed and should yield a fail status.
  2. In cases where validations fail, but no corrective action was applied, we use a weak check to determine a fail status. A better more comprehensive check would be to check all values against the before values in failed validations.

@CalebCourier CalebCourier merged commit eb42b39 into main Jan 5, 2024
61 checks passed
@CalebCourier CalebCourier deleted the status-fix branch January 9, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsimjee zsimjee zsimjee approved these changes

@thekaranacharya thekaranacharya Awaiting requested review from thekaranacharya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalebCourier @zsimjee