Share URIs for valid file / file paths only #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ignore URIs for trigger for which getMimeType() or getPath() is null Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While sharing an
Eventconsisting of anyEventTriggers for which we do not have a file we get a toast "Couldn't attach file". For multiple such triggers in one event the toast persists for a long time. This may result in very disturbing user experience. This PR aims to solve that.This will also close #181 since that crash was caused by NPE while attempting to create a
Filefrom a null string.