Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to create GitHub App: use pull_requests with underscore #41

Merged
merged 1 commit into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Fix link to create GitHub App: use pull_requests with underscore

    This fixes a small documentation mistake I made in #26,
    where usage of a Github App was introduced. I supplied a link in the docs to help create a new GitHub App, this link was
    supposed to pre-populate the form with the 3 necessary permissions (Contents: Read and write, Pull Requests: Read and write,
    and Metadata: Read-only). However, checking it now, it only provides 2 of 3, and the 'Pull Requests' permission wasn't
    set.
    
    It turned out that I should have been using `pull_requests=write` in the url, rather than `pull-requests=write` - this
    isn't documented, so far as I can see:
    
    https://docs.github.com/en/apps/sharing-github-apps/registering-a-github-app-using-url-parameters
    
    ...but in the end I managed to guess it!
    rtyley committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3ad5011 View commit details
    Browse the repository at this point in the history