Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explain GitHub App needs access to each repo #32

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Mar 19, 2024

Following on from #26, which introduced the need to have a GitHub App, this updates the docs further to explain that the GitHub App must be granted access to each repo that it acts upon.

If the GitHub App does not have access to the repo, the release flow will fail:

Maven Release / 🔒 Push Release Commit
Not Found - https://docs.github.com/rest/apps/apps#get-a-repository-installation-for-the-authenticated-app

image

Following on from #26,
which introduced the need to have a GitHub App, this updates the docs
further to explain that the GitHub App must be granted access to each
repo that it acts upon.

If the GitHub App does not have access to the repo, the release flow
will fail, like https://github.com/guardian/content-entity/actions/runs/8347150774 :

> Maven Release / 🔒 Push Release Commit
> Not Found - https://docs.github.com/rest/apps/apps#get-a-repository-installation-for-the-authenticated-app
Comment on lines +8 to +11
1. [Create the GitHub App](github-app.md) to perform actions on your repos, like pushing commits and making PR comments.
2. [Generate release credentials](credentials/generating-credentials.md) (ie Sonatype account, PGP key, etc) and
get ready to [supply them to the workflow](credentials/supplying-credentials.md).
3. [Configure your repos](configuration.md) to use the release workflow.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are just making this page a bit more concise!

@rtyley rtyley marked this pull request as ready for review March 19, 2024 17:47
@rtyley rtyley requested a review from Divs-B March 19, 2024 17:47
@Divs-B
Copy link

Divs-B commented Mar 20, 2024

I followed these instructions for adding content-entity :

image

@rtyley
Copy link
Member Author

rtyley commented Mar 20, 2024

As in demonstrated in the comment above, @Divs-B was kind enough to verify that she could grant the gu-scala-library-release GitHub App access to selected repositories, so long as she was an admin on those repos - you don't need any more elevated permission than that (eg, she was not an App manager or Organisation owner).

@rtyley rtyley merged commit b3af37b into main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants