Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass creds for gu-scala-library-release GitHub App #42

Merged

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Feb 24, 2024

This change passes on the new AUTOMATED_MAVEN_RELEASE_GITHUB_APP_PRIVATE_KEY Organisation Secret required for guardian/gha-scala-library-release-workflow#26 - a GitHub App private key for https://github.com/apps/gu-scala-library-release.

This allows gha-scala-library-release-workflow to work with repos that use branch-protection rulesets that prevent most users from pushing to the default (main) branch - the workflow can authenticate as our GitHub App, and our GitHub App can be granted permission to bypass the ruleset, so that it can push to main to make a release, while developers can not!

This change passes on the new `AUTOMATED_MAVEN_RELEASE_GITHUB_APP_PRIVATE_KEY`
Organisation Secret required for guardian/gha-scala-library-release-workflow#26 -
a GitHub App **private** key for https://github.com/apps/gu-scala-library-release .

This allows `gha-scala-library-release-workflow` to work with repos that
use branch-protection rulesets that prevent most users from pushing to
the default (`main`) branch - the workflow can authenticate as our
GitHub App, and our GitHub App can be granted permission to bypass the
ruleset, so that it can push to `main` to make a release, while
developers can not!
@guardian guardian deleted a comment from github-actions bot Feb 24, 2024
@rtyley rtyley marked this pull request as ready for review February 26, 2024 08:49
@rtyley rtyley merged commit 6326eb1 into main Feb 27, 2024
2 checks passed
@rtyley rtyley deleted the pass-credentials-for-gu-scala-library-release-GitHub-App branch February 27, 2024 18:26
rtyley added a commit to guardian/atom-maker that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/commercial-shared that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/content-api-client-aws that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/content-api-firehose-client that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/content-api-scala-client that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/cross-platform-navigation that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/facia-scala-client that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/fezziwig that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/identity-test-users that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/marley that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/mobile-apps-api-models that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/pa-football-client that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/play-googleauth that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/play-secret-rotation that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/scrooge-extras that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/tags-thrift-schema that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/targeting-client that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/thrift-serializer that referenced this pull request Feb 27, 2024
rtyley added a commit to guardian/content-api-models that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant