Use product and ratePlan qs params over amounts for support epic #12403
+154
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +265 B (+0.03%) Total Size: 938 kB
ℹ️ View Unchanged
|
jamesgorrie
force-pushed
the
use-product-for-selected-tier
branch
from
f6d4979
to
6b626e1
Compare
jamesgorrie
force-pushed
the
use-product-for-selected-tier
branch
from
6b626e1
to
ae37cc4
Compare
jamesgorrie
force-pushed
the
use-product-for-selected-tier
branch
from
ae37cc4
to
961712f
Compare
jamesgorrie
changed the title
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
…otcom-rendering into use-product-for-selected-tier
…product-for-selected-tier
|
Currently the banner links to the landing page with e.g. |
@tomrf1 this currently works, but we want to remove those qs parameters as it just adds another level of transformation and complexity. This PR adds the functionality of being able to use the |
github-actions
bot
removed
the
run_chromatic
jamesgorrie
commented
Sep 19, 2024
| @@ -139,6 +137,9 @@ export const design: ConfigurableDesign = { | |||
| filledProgress: stringToHexColour('052962'), | |||
| progressBarBackground: stringToHexColour('cccccc'), | |||
| goalMarker: stringToHexColour('000000'), | |||
| goalColour: stringToHexColour('000000'), | |||
| headlineColour: stringToHexColour('000000'), | |||
| totalColour: stringToHexColour('000000'), | |||
There was a problem hiding this comment.
These are new properties needed for the version bump - assuming this should have been a breaking change but wasn't.
There was a problem hiding this comment.
The related change is blocked by a source upgrade, but I think your update here is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses the
productandratePlanvalues on the links through to support.theguardian.com.Updates
guardian/support-dotcom-components(additive and patch, so won't have any backwards compatibility issues)Why?
On
support-frontendwe are moving away from using multiple layers of transformations, especially from amount => product, but rather using product directly, and trying to maintain the model and values as close to the Product API as possible.The URLs are now as follows (with tracking params omitted for clarity)
/us/checkout?product=Contribution&ratePlan=Monthly/us/checkout?product=SupporterPlus&ratePlan=Monthly/us/contribute/checkout?selected-contribution-type=ONE_OFF/uk/contribution?product=Contribution&ratePlan=Monthly/uk/contribution?product=SupporterPlus&ratePlan=Monthly/uk/contributeDepends on
Non-US
Screen.Recording.2024-09-19.at.11.26.12.mov
US
Screen.Recording.2024-09-19.at.11.36.43.mov