[Fairground 🎡] Redesign sublinks as grid layout #12346
Open
+159
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeddow91
changed the title
|
Size Change: +742 B (+0.08%) Total Size: 939 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
abeddow91
force-pushed
the
ab/trail-redesign
branch
from
8c06abf
to
5b2878b
Compare
abeddow91
commented
Sep 12, 2024
abeddow91
commented
Sep 12, 2024
abeddow91
force-pushed
the
ab/trail-redesign
branch
4 times, most recently
from
c19bd40
to
d4ee02a
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Totes unrelated, but hoping this will allow to make them accessible and react to font size changes like (mostly) the rest of the fronts:
|
cemms1
approved these changes
Sep 18, 2024
Comment on lines
+20
to
+37
| /** | ||
| * Returns the column span for the grid layout based on the number of supporting content items. | ||
| * | ||
| * @param {number} contentLength - The number of supporting content items. | ||
| * @returns {number} The column span to use in the grid layout. | ||
| */ | ||
| const getColumnSpan = (contentLength: number): number => { | ||
| switch (contentLength) { | ||
| case 1: | ||
| case 2: | ||
| return 6; | ||
| case 3: | ||
| return 4; | ||
| case 4: | ||
| default: | ||
| return 3; // Default column span for 4 or more items |
…ial (#12402) * Add background colour to mobile sublinks for flex special
Co-authored-by: Charlotte Emms <43961396+cemms1@users.noreply.github.com>
Co-authored-by: Charlotte Emms <43961396+cemms1@users.noreply.github.com>
abeddow91
force-pushed
the
ab/trail-redesign
branch
from
99846e8
to
8de1c6a
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change updates the sublinks on cards to use a grid layout instead of a flex layout. The grid layout ensures a consistent, fixed width for sublinks on tablet devices and larger screens, aligning them with the Guardian's 12-column grid system. This keeps the sublinks properly aligned with the surrounding content.
Why?
As part of the fairground redesign, we are updating the appearance of sublinks. Specifically, we want to increase the width of the dividing line on vertically stacked cards and position it between sublinks on horizontally stacked cards. However, while implementing these changes, we noticed that the sublinks were not aligning correctly with the rest of the content within the grid. Switching to a grid layout gives us more control over the width distribution of sublinks and ensures they align properly with the adjacent stories.
Screenshots
Vertical stacked cards
Horizontal stacked cards