Skip to content

Commit

Permalink
Merge branch 'main' of github.com:guardian/dotcom-rendering into use-…
Browse files Browse the repository at this point in the history
…product-for-selected-tier
  • Loading branch information
jamesgorrie committed Sep 19, 2024
2 parents 6d2311c + f53da77 commit efab82a
Show file tree
Hide file tree
Showing 5 changed files with 536 additions and 139 deletions.
2 changes: 1 addition & 1 deletion dotcom-rendering/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@guardian/bridget": "7.0.0",
"@guardian/browserslist-config": "6.1.0",
"@guardian/cdk": "50.13.0",
"@guardian/commercial": "19.12.0",
"@guardian/commercial": "21.0.3",
"@guardian/core-web-vitals": "7.0.0",
"@guardian/eslint-config": "7.0.1",
"@guardian/eslint-config-typescript": "9.0.1",
Expand Down
11 changes: 3 additions & 8 deletions dotcom-rendering/src/layouts/InteractiveLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,9 @@ export const InteractiveLayout = (props: WebProps | AppsProps) => {
</Stuck>
)}

{renderAds &&
article.config.switches.surveys &&
hasSurveyAd && (
<AdSlot
position="survey"
display={format.display}
/>
)}
{renderAds && hasSurveyAd && (
<AdSlot position="survey" display={format.display} />
)}
</>
)}
<main data-layout="InteractiveLayout">
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/NewsletterSignupLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export const NewsletterSignupLayout = ({ article, NAV, format }: Props) => {
/>
</div>

{renderAds && !!article.config.switches.surveys && hasSurveyAd && (
{renderAds && hasSurveyAd && (
<AdSlot position="survey" display={format.display} />
)}

Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/StandardLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {
</Stuck>
)}

{renderAds && article.config.switches.surveys && hasSurveyAd && (
{renderAds && hasSurveyAd && (
<AdSlot position="survey" display={format.display} />
)}

Expand Down
Loading

0 comments on commit efab82a

Please sign in to comment.